netdev - Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8827ff6b60d73ca6484365d25f72ec82ac106c40.camel@perches.com>
Date:   Sat, 23 Feb 2019 14:13:04 -0800
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>, laoar.shao@...il.com
Cc:     daniel@...earbox.net, edumazet@...gle.com,
        xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        shaoyafang@...iglobal.com
Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING

On Sat, 2019-02-23 at 13:21 -0800, David Miller wrote:
> From: Yafang Shao <laoar.shao@...il.com>
> Date: Sun, 17 Feb 2019 22:26:32 +0800
> 
> > SOCK_DEBUG() is a old facility for debugging.
> > If the user want to use it for debugging, the user must modify the
> > application first, that doesn't seem like a good way.
> > Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind
> > of debugging purpose.
> > So we'd better disable it by default.
> > The reason why I don't remove it comepletely is that someone may still
> > would like to use it for debugging.
> > 
> > Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> > Suggested-by: Joe Perches <joe@...ches.com>
> 
> Sorry, I'm not applying this.
> 
> You are forcing everyone who wants to use this to add a curstom local
> source code change into their build.

That may not actually be a bad thing.
It could become a CONFIG bit too.

I'm not sure how often it's actually used.

Outside of the likely to be removed tcp uses, it's
currently used only in appletalk/ddp, x25, and the 1 use
in dccp.

All of the existing uses could likely be removed without
much notice by anyone.