lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d6f79c5a-57c6-87e2-5408-b778f58838b3@gmail.com> Date: Sun, 24 Feb 2019 21:35:11 +0100 From: Heiner Kallweit <hkallweit1@...il.com> To: David Miller <davem@...emloft.net>, Maxime Chevallier <maxime.chevallier@...tlin.com> Cc: netdev@...r.kernel.org Subject: Re: marvell10g.c merge into net-next On 24.02.2019 21:15, David Miller wrote: > > Heiner, please look at net-next which I just merged net into. > > Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK > bits are cleared in the 10gbt control register to work around > a problem with some marvell10g phy chips. > > In the merge I preserved your usage of the generic c45 helpers > in this area, but I suspect part of that will have to be undone > in order to accomodate the above fix. > Thanks for the info. Let me add Maxime as author of the fix. I think we talk about his one "net: phy: marvell10g: Fix Multi-G advertisement to only advertise 10G" and we talk about net-next. IMO the proper way to fix this is removing the unsupported modes from phydev->advertising in config_init. Then mv3310_config_aneg doesn't have to be touched. A similar exercise I did here: 0974f1f03b07 ("net: phy: aquantia: remove false 5G and 10G speed ability for AQCS109") > Thanks. > Heiner
Powered by blists - more mailing lists