netdev - Re: [PATCH net-next] net: Skip GSO length estimation if transport header is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190224.124105.1191332252128380264.davem@davemloft.net>
Date:   Sun, 24 Feb 2019 12:41:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     maximmi@...lanox.com
Cc:     willemb@...gle.com, saeedm@...lanox.com, jasowang@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org, eranbe@...lanox.com,
        tariqt@...lanox.com
Subject: Re: [PATCH net-next] net: Skip GSO length estimation if transport
 header is not set

From: Maxim Mikityanskiy <maximmi@...lanox.com>
Date: Fri, 22 Feb 2019 12:55:22 +0000

> qdisc_pkt_len_init expects transport_header to be set for GSO packets.
> Patch [1] skips transport_header validation for GSO packets that don't
> have network_header set at the moment of calling virtio_net_hdr_to_skb,
> and allows them to pass into the stack. After patch [2] no placeholder
> value is assigned to transport_header if dissection fails, so this patch
> adds a check to the place where the value of transport_header is used.
> 
> [1] https://patchwork.ozlabs.org/patch/1044429/
> [2] https://patchwork.ozlabs.org/patch/1046122/
> 
> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>

Applied, thanks Maxim.