netdev - Re: [PATCH net] net/x25: fix a race in x25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190223.184254.1384538225076694532.davem@davemloft.net>
Date:   Sat, 23 Feb 2019 18:42:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        andrew.hendry@...il.com
Subject: Re: [PATCH net] net/x25: fix a race in x25_bind()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat, 23 Feb 2019 13:24:59 -0800

> syzbot was able to trigger another soft lockup [1]
> 
> I first thought it was the O(N^2) issue I mentioned in my
> prior fix (f657d22ee1f "net/x25: do not hold the cpu
> too long in x25_new_lci()"), but I eventually found
> that x25_bind() was not checking SOCK_ZAPPED state under
> socket lock protection.
> 
> This means that multiple threads can end up calling
> x25_insert_socket() for the same socket, and corrupt x25_list
 ...
> Fixes: 90c27297a9bf ("X.25 remove bkl in bind")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: andrew hendry <andrew.hendry@...il.com>

Applied and queued up for -stable, thanks Eric.