netdev - Re: [PATCH net] tcp: repaired skbs must init their tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190223.184445.2205772277164473282.davem@davemloft.net>
Date:   Sat, 23 Feb 2019 18:44:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, soheil@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com,
        syzkaller@...glegroups.com, avagin@...nvz.org
Subject: Re: [PATCH net] tcp: repaired skbs must init their tso_segs

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat, 23 Feb 2019 15:51:51 -0800

> syzbot reported a WARN_ON(!tcp_skb_pcount(skb))
> in tcp_send_loss_probe() [1]
> 
> This was caused by TCP_REPAIR sent skbs that inadvertenly
> were missing a call to tcp_init_tso_segs()
 ...
> Fixes: 79861919b889 ("tcp: fix TCP_REPAIR xmit queue setup")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable.