netdev - Re: [PATCH net] tcp: repaired skbs must init their tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQyk=pfq45z_Oo=jUc3+h2w5848u7HnikbhQoTGKp5UwnOg@mail.gmail.com>
Date:   Sat, 23 Feb 2019 20:17:27 -0500
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        syzbot <syzkaller@...glegroups.com>,
        Andrey Vagin <avagin@...nvz.org>
Subject: Re: [PATCH net] tcp: repaired skbs must init their tso_segs

On Sat, Feb 23, 2019 at 6:51 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> syzbot reported a WARN_ON(!tcp_skb_pcount(skb))
> in tcp_send_loss_probe() [1]
>
> This was caused by TCP_REPAIR sent skbs that inadvertenly
> were missing a call to tcp_init_tso_segs()
>

Acked-by: Neal Cardwell <ncardwell@...gle.com>

Thanks, Eric!

neal