| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201903020318.LoVaMhnk%fengguang.wu@intel.com>
Date: Sat, 2 Mar 2019 03:41:13 +0800
From: kbuild test robot <lkp@...el.com>
To: Arjun Vynipadath <arjun@...lsio.com>
Cc: kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
nirranjan@...lsio.com, indranil@...lsio.com, dt@...lsio.com,
Arjun Vynipadath <arjun@...lsio.com>,
Vishal Kulkarni <vishal@...lsio.com>
Subject: Re: [PATCH net-next] cxgb4: Prefix adapter flags with CXGB4
Hi Arjun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Arjun-Vynipadath/cxgb4-Prefix-adapter-flags-with-CXGB4/20190302-015236
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.2.0 make.cross ARCH=sparc64
All errors (new ones prefixed by >>):
drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'chtls_listen_start':
>> drivers/crypto/chelsio/chtls/chtls_cm.c:619:22: error: 'FULL_INIT_DONE' undeclared (first use in this function); did you mean 'CXGB4_FULL_INIT_DONE'?
if (!(adap->flags & FULL_INIT_DONE))
^~~~~~~~~~~~~~
CXGB4_FULL_INIT_DONE
drivers/crypto/chelsio/chtls/chtls_cm.c:619:22: note: each undeclared identifier is reported only once for each function it appears in
vim +619 drivers/crypto/chelsio/chtls/chtls_cm.c
cc35c88a Atul Gupta 2018-03-31 598
cc35c88a Atul Gupta 2018-03-31 599 int chtls_listen_start(struct chtls_dev *cdev, struct sock *sk)
cc35c88a Atul Gupta 2018-03-31 600 {
cc35c88a Atul Gupta 2018-03-31 601 struct net_device *ndev;
cc35c88a Atul Gupta 2018-03-31 602 struct listen_ctx *ctx;
cc35c88a Atul Gupta 2018-03-31 603 struct adapter *adap;
cc35c88a Atul Gupta 2018-03-31 604 struct port_info *pi;
cc35c88a Atul Gupta 2018-03-31 605 int stid;
cc35c88a Atul Gupta 2018-03-31 606 int ret;
cc35c88a Atul Gupta 2018-03-31 607
cc35c88a Atul Gupta 2018-03-31 608 if (sk->sk_family != PF_INET)
cc35c88a Atul Gupta 2018-03-31 609 return -EAGAIN;
cc35c88a Atul Gupta 2018-03-31 610
cc35c88a Atul Gupta 2018-03-31 611 rcu_read_lock();
cc35c88a Atul Gupta 2018-03-31 612 ndev = chtls_ipv4_netdev(cdev, sk);
cc35c88a Atul Gupta 2018-03-31 613 rcu_read_unlock();
cc35c88a Atul Gupta 2018-03-31 614 if (!ndev)
cc35c88a Atul Gupta 2018-03-31 615 return -EBADF;
cc35c88a Atul Gupta 2018-03-31 616
cc35c88a Atul Gupta 2018-03-31 617 pi = netdev_priv(ndev);
cc35c88a Atul Gupta 2018-03-31 618 adap = pi->adapter;
cc35c88a Atul Gupta 2018-03-31 @619 if (!(adap->flags & FULL_INIT_DONE))
cc35c88a Atul Gupta 2018-03-31 620 return -EBADF;
cc35c88a Atul Gupta 2018-03-31 621
cc35c88a Atul Gupta 2018-03-31 622 if (listen_hash_find(cdev, sk) >= 0) /* already have it */
cc35c88a Atul Gupta 2018-03-31 623 return -EADDRINUSE;
cc35c88a Atul Gupta 2018-03-31 624
cc35c88a Atul Gupta 2018-03-31 625 ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
cc35c88a Atul Gupta 2018-03-31 626 if (!ctx)
cc35c88a Atul Gupta 2018-03-31 627 return -ENOMEM;
cc35c88a Atul Gupta 2018-03-31 628
cc35c88a Atul Gupta 2018-03-31 629 __module_get(THIS_MODULE);
cc35c88a Atul Gupta 2018-03-31 630 ctx->lsk = sk;
cc35c88a Atul Gupta 2018-03-31 631 ctx->cdev = cdev;
cc35c88a Atul Gupta 2018-03-31 632 ctx->state = T4_LISTEN_START_PENDING;
cc35c88a Atul Gupta 2018-03-31 633 skb_queue_head_init(&ctx->synq);
cc35c88a Atul Gupta 2018-03-31 634
cc35c88a Atul Gupta 2018-03-31 635 stid = cxgb4_alloc_stid(cdev->tids, sk->sk_family, ctx);
cc35c88a Atul Gupta 2018-03-31 636 if (stid < 0)
cc35c88a Atul Gupta 2018-03-31 637 goto free_ctx;
cc35c88a Atul Gupta 2018-03-31 638
cc35c88a Atul Gupta 2018-03-31 639 sock_hold(sk);
cc35c88a Atul Gupta 2018-03-31 640 if (!listen_hash_add(cdev, sk, stid))
cc35c88a Atul Gupta 2018-03-31 641 goto free_stid;
cc35c88a Atul Gupta 2018-03-31 642
cc35c88a Atul Gupta 2018-03-31 643 ret = cxgb4_create_server(ndev, stid,
cc35c88a Atul Gupta 2018-03-31 644 inet_sk(sk)->inet_rcv_saddr,
cc35c88a Atul Gupta 2018-03-31 645 inet_sk(sk)->inet_sport, 0,
cc35c88a Atul Gupta 2018-03-31 646 cdev->lldi->rxq_ids[0]);
cc35c88a Atul Gupta 2018-03-31 647 if (ret > 0)
cc35c88a Atul Gupta 2018-03-31 648 ret = net_xmit_errno(ret);
cc35c88a Atul Gupta 2018-03-31 649 if (ret)
cc35c88a Atul Gupta 2018-03-31 650 goto del_hash;
cc35c88a Atul Gupta 2018-03-31 651 return 0;
cc35c88a Atul Gupta 2018-03-31 652 del_hash:
cc35c88a Atul Gupta 2018-03-31 653 listen_hash_del(cdev, sk);
cc35c88a Atul Gupta 2018-03-31 654 free_stid:
cc35c88a Atul Gupta 2018-03-31 655 cxgb4_free_stid(cdev->tids, stid, sk->sk_family);
cc35c88a Atul Gupta 2018-03-31 656 sock_put(sk);
cc35c88a Atul Gupta 2018-03-31 657 free_ctx:
cc35c88a Atul Gupta 2018-03-31 658 kfree(ctx);
cc35c88a Atul Gupta 2018-03-31 659 module_put(THIS_MODULE);
cc35c88a Atul Gupta 2018-03-31 660 return -EBADF;
cc35c88a Atul Gupta 2018-03-31 661 }
cc35c88a Atul Gupta 2018-03-31 662
:::::: The code at line 619 was first introduced by commit
:::::: cc35c88ae4db219611e204375d6a4248bc0e84d6 crypto : chtls - CPL handler definition
:::::: TO: Atul Gupta <atul.gupta@...lsio.com>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (56375 bytes)
Powered by blists - more mailing lists