netdev - Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac71113e7f7e95d48d208d7d02a606dc712e41e0.camel@mellanox.com>
Date:   Fri, 1 Mar 2019 19:43:23 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "pablo@...filter.org" <pablo@...filter.org>,
        Roi Dayan <roid@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>
Subject: Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when
 allocating pedit action

On Wed, 2019-02-27 at 21:02 +0100, Pablo Neira Ayuso wrote:
> On Wed, Feb 27, 2019 at 02:05:02PM +0000, Roi Dayan wrote:
> > 
> > On 26/02/2019 14:28, xiangxia.m.yue@...il.com wrote:
> > > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> > > 
> > > The capacity of FDB offloading and NIC offloading table are
> > > different, and when allocating the pedit actions, we should
> > > use the correct namespace type.
> > > 
> > > Fixes: c500c86b0c75d ("net/mlx5e: support for two independent
> > > packet edit actions")
> > > Cc: Pablo Neira Ayuso <pablo@...filter.org>
> > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> > > ---
> > >  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > index 3a02b22..467ef9e 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > > @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct
> > > mlx5e_priv *priv,
> > >  
> > >  	if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
> > >  	    hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> > > -		err = alloc_tc_pedit_action(priv,
> > > MLX5_FLOW_NAMESPACE_KERNEL,
> > > +		err = alloc_tc_pedit_action(priv,
> > > MLX5_FLOW_NAMESPACE_FDB,
> > >  					    parse_attr, hdrs, extack);
> > >  		if (err)
> > >  			return err;
> > > 
> > 
> > Reviewed-by: Roi Dayan <roid@...lanox.com>
> 
> Acked-by: Pablo Neira Ayuso <pablo@...filter.org>

Acked-by: Saeed Mahameed <saeedm@...lanox.com>

Dave, can you please apply this directly to net-next ?

Thanks,
Saeed.