netdev - Re: [RFC v2 5/6] mlx4: report errors through extack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Feb 2019 19:07:30 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC v2 5/6] mlx4: report errors through extack

On Thu, 28 Feb 2019 13:54:40 -0800, Stephen Hemminger wrote:
> @@ -2870,8 +2873,8 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog)
>  	if (port_up) {
>  		err = mlx4_en_start_port(dev);
>  		if (err) {
> -			en_err(priv, "Failed starting port %d for XDP change\n",
> -			       priv->port);
> +			NL_SET_ERR_MSG_MOD(extack,
> +				       "Failed starting port for XDP change");

alignment is off now in a few spots

>  			queue_work(mdev->workqueue, &priv->watchdog_task);
>  		}
>  	}