netdev - Re: [PATCH bpf-next v2 1/7] bpf: implement lookup-free direct value access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201903011156.zkhdzK8C%fengguang.wu@intel.com>
Date:   Fri, 1 Mar 2019 11:58:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     kbuild-all@...org, ast@...com, bpf@...r.kernel.org,
        netdev@...r.kernel.org, joe@...d.net.nz, john.fastabend@...il.com,
        tgraf@...g.ch, yhs@...com, andriin@...com,
        jakub.kicinski@...ronome.com, lmb@...udflare.com,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next v2 1/7] bpf: implement lookup-free direct value
 access

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Daniel-Borkmann/BPF-support-for-global-data/20190301-112203
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-x017-201908 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-21) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   kernel//bpf/arraymap.c: In function 'array_map_direct_value_offset':
>> kernel//bpf/arraymap.c:182:24: warning: initialization of 'long unsigned int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
     unsigned long base  = array->value;
                           ^~~~~

vim +182 kernel//bpf/arraymap.c

   176	
   177	static int array_map_direct_value_offset(const struct bpf_map *map, u64 imm,
   178						 u32 *off)
   179	{
   180		struct bpf_array *array = container_of(map, struct bpf_array, map);
   181		unsigned long range = map->value_size;
 > 182		unsigned long base  = array->value;
   183		unsigned long addr  = imm;
   184	
   185		if (map->max_entries != 1)
   186			return -ENOENT;
   187		if (addr < base || addr >= base + range)
   188			return -ENOENT;
   189	
   190		*off = addr - base;
   191		return 0;
   192	}
   193	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30095 bytes)