netdev - Re: [PATCH net] qmi_wwan: Add support for Quectel EG12/EM12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o96t9v93.fsf@miraculix.mork.no>
Date:   Sat, 02 Mar 2019 16:00:24 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Kristian Evensen <kristian.evensen@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] qmi_wwan: Add support for Quectel EG12/EM12

Kristian Evensen <kristian.evensen@...il.com> writes:

> Quectel EG12 (module)/EM12 (M.2 card) is a Cat. 12 LTE modem. The modem
> behaves in the same way as the EP06, so the "set DTR"-quirk must be
> applied and the diagnostic-interface check performed. Since the
> diagnostic-check now applies to more modems, I have renamed the function
> from quectel_ep06_diag_detected() to quectel_diag_detected().

I am not too happy about the double device id matching with extra magic
applied. outside the device id table.  It does not scale, and it does
not play well at all with dynamic IDs.  But I guess it's acceptable for
two devices when it was ok for one, so

Acked-by: Bjørn Mork <bjorn@...k.no>

But I assume this isn't the last device we've seen with this issue.
Someone has already mention Quectel EM20. Maybe convert this code to a
quirk for the next device and leave all the device specific magic in the
device id table?  Could even add a macro for the class match + quirk
thing.

Bjørn