lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 2 Mar 2019 22:19:13 +0100
From:   Kristian Evensen <>
To:     Bjørn Mork <>
Cc:     Network Development <>,
        David Miller <>
Subject: Re: [PATCH net] qmi_wwan: Add support for Quectel EG12/EM12

On Sat, Mar 2, 2019 at 4:00 PM Bjørn Mork <> wrote:
> I am not too happy about the double device id matching with extra magic
> applied. outside the device id table.  It does not scale, and it does
> not play well at all with dynamic IDs.  But I guess it's acceptable for
> two devices when it was ok for one, so
> Acked-by: Bjørn Mork <>
> But I assume this isn't the last device we've seen with this issue.
> Someone has already mention Quectel EM20. Maybe convert this code to a
> quirk for the next device and leave all the device specific magic in the
> device id table?  Could even add a macro for the class match + quirk
> thing.

(Appologies to Bjørn for receiving multiple copies of this email - I
forgot that the Gmail app sends HTML-encoded emails)

Thanks for your feedback. My reasoning was the same. For one or two
devices, the current approach is (probably) ok. Any more, and a
different approach is needed.

Looking through the documentation I have, it seems like most
Quectel-modems support the command used to change the
USB-configuration. Thus, I wouldn’t be surprised if all or most
existing Quectel-devices should have this quirk applied. I have a
couple of older modules, so I will look at how they behave with
different configurations. I will then either add the quirk soon or
when for example EM20 is available (unless someone else does it
earlier :)).


Powered by blists - more mailing lists