netdev - Re: [PATCH v1 1/7] enc28j60: Use device_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6730380b989aaaa83aaaa06bd4e22bcd11171d75.camel@perches.com>
Date:   Fri, 01 Mar 2019 21:56:53 -0800
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>,
        andriy.shevchenko@...ux.intel.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v1 1/7] enc28j60: Use device_get_mac_address()

On Fri, 2019-03-01 at 21:46 -0800, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Date: Thu, 28 Feb 2019 23:34:29 +0300
> 
> > @@ -1554,7 +1554,7 @@ static int enc28j60_probe(struct spi_device *spi)
> >  {
> >       struct net_device *dev;
> >       struct enc28j60_net *priv;
> > -     const void *macaddr;
> > +     unsigned char macaddr[ETH_ALEN];
> >       int ret = 0;
> 
> Preserve the reverse christmas tree here please.

There is no reverse christmas tree here.