netdev - Re: [PATCH net] geneve: correctly handle ipv6.disable module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 01 Mar 2019 22:08:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jbenc@...hat.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] geneve: correctly handle ipv6.disable module
 parameter

From: Jiri Benc <jbenc@...hat.com>
Date: Thu, 28 Feb 2019 14:56:04 +0100

> When IPv6 is compiled but disabled at runtime, geneve_sock_add returns
> -EAFNOSUPPORT. For metadata based tunnels, this causes failure of the whole
> operation of bringing up the tunnel.
> 
> Ignore failure of IPv6 socket creation for metadata based tunnels caused by
> IPv6 not being available.
> 
> This is the same fix as what commit d074bf960044 ("vxlan: correctly handle
> ipv6.disable module parameter") is doing for vxlan.
> 
> Note there's also commit c0a47e44c098 ("geneve: should not call rt6_lookup()
> when ipv6 was disabled") which fixes a similar issue but for regular
> tunnels, while this patch is needed for metadata based tunnels.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied and queued up for -stable, thanks Jiri.