netdev - Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190304135305.GD26378@lunn.ch>
Date:   Mon, 4 Mar 2019 14:53:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

> I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge
> membership callbacks, and as I don't happen to know nearly enough about DSA, I
> wonder at what moment in time does forwarding get activated between ports.

If those callbacks are not implement, it means the software bridge
does the forwarding. The hardware is not used.

The DSA model allows you to start simple and just implement something
like a port multiplexor. All frames get passed to the host, and the
host then decides what to do with them.

You can then add more callbacks and make more use of the hardware,
e.g. get the hardware to bridge between ports.

If the hardware is not capable of supporting vlan filtering, but you
can support simpler modes, you should implement what you can, and
return an error when asked to do something which it cannot support.

       Andrew