netdev - Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+h21hqN5z+eEb4nsYGCsizY1jfphr=FZQubtNNhMw86Pfj5Kg@mail.gmail.com>
Date:   Mon, 4 Mar 2019 16:10:07 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

On Mon, 4 Mar 2019 at 15:53, Andrew Lunn <andrew@...n.ch> wrote:
>
> > I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge
> > membership callbacks, and as I don't happen to know nearly enough about DSA, I
> > wonder at what moment in time does forwarding get activated between ports.
>
> If those callbacks are not implement, it means the software bridge
> does the forwarding. The hardware is not used.
>
> The DSA model allows you to start simple and just implement something
> like a port multiplexor. All frames get passed to the host, and the
> host then decides what to do with them.
>
> You can then add more callbacks and make more use of the hardware,
> e.g. get the hardware to bridge between ports.
>
> If the hardware is not capable of supporting vlan filtering, but you
> can support simpler modes, you should implement what you can, and
> return an error when asked to do something which it cannot support.
>
>        Andrew

Hi Andrew,

Thank you for the explanation, it does make sense.
Would you mind sharing a thought about the feasability of DSA_TAG_PROTO_8021Q
in light of the required handling that was discussed in the previous emails?

Regards,
-Vladimir