netdev - Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f59de4af-df2c-1ec1-0a36-18bdcfa3e247@oracle.com>
Date:   Tue, 5 Mar 2019 08:48:44 -0800
From:   Gerd Rausch <gerd.rausch@...cle.com>
To:     Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        netdev@...r.kernel.org, davem@...emloft.net
Cc:     yanjun.zhu@...cle.com
Subject: Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

Hi Santosh,

On 05/03/2019 08.41, Santosh Shilimkar wrote:
> On 3/5/2019 8:33 AM, Gerd Rausch wrote:
>> If there's a mechanism that ensures compatibility with older (pre-4.1) versions
>> of RDS I am not seeing it.
> Thats handled as part of the connection reject handler as part of negotiation.
> 

Evidentally, that mechanism isn't working properly.

>> The inconsistency in comment vs. code doesn't help in that regard.
>>
> Yeah the comment should have been updated.
> 

>> And tests illustrated this incompatibility:
>> 2 peers with this patchset can talk to eachother.
>> Peers with a mix of post-this-patchset and pre-this-patchset can no longer talk
>> to eachother.
>>
> They can talk to each other as per Yanjun tests.

I am happy to hear it worked for him, but is it possible that his tests may have been incomplete?

In a unicast e-mail conversation with Yanjun, he acknowledged:
"Now I found another hosts and I can reproduce Gerd's bug on the hosts. Now I am working on the hosts to find the root cause."

So we have non-working code in David's repository, which I consider not to be a good thing.

> He is working on setting it up net-next to see if something got missed out.
> Stay tune. Will update about the results.
> 

Can we back this patchset out again until we have working & compatible code?

Thanks,

  Gerd