netdev - Re: question about memory leak in ip_mc_del1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190305.090020.1424252324111549025.davem@davemloft.net>
Date:   Tue, 05 Mar 2019 09:00:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru
Subject: Re: question about memory leak in ip_mc_del1_src

From: maowenan <maowenan@...wei.com>
Date: Tue, 5 Mar 2019 11:33:03 +0800

> 
> 
> On 2019/3/5 2:16, David Miller wrote:
>> From: maowenan <maowenan@...wei.com>
>> Date: Mon, 4 Mar 2019 20:47:42 +0800
>> 
>>> 			pmc->tomb = psf;
>>> 			rv = 1;         //if it does not kfree(psf), will it lead to memory leak after this line?
>> 
>> pmc->tomb points to psf, why should we free it?
> 
> Thank you David.
> Yes, pmc->tomb points to psf, but this is a delete path
> for ip_mc_add1_src, if we don't free psf, where it can be done?

When the 'pmc' object is destroyed.