netdev - Re: [PATCH bpf] bpf: only test gso type on gso packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3MdRWxi+miQZfSvBABW3o_E=vPgLUi3NLyxNf4yXFXf0JU7Q@mail.gmail.com>
Date:   Wed, 6 Mar 2019 17:34:20 -0800
From:   Y Song <ys114321@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf] bpf: only test gso type on gso packets

On Wed, Mar 6, 2019 at 1:15 PM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> From: Willem de Bruijn <willemb@...gle.com>
>
> BPF can adjust gso only for tcp bytestreams. Fail on other gso types.
>
> But only on gso packets. It does not touch this field if !gso_size.
Could you specify which field you are referring here?
gso_type, gso_segs, gso_size?

>
> Fixes: b90efd225874 ("bpf: only adjust gso_size on bytestream protocols")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Other than the above commit message suggestion,
Acked-by: Yonghong Song <yhs@...com>