netdev - Re: [PATCH bpf] bpf: only test gso type on gso packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2993173-b434-d87e-36fa-5a93b797698a@iogearbox.net>
Date:   Thu, 7 Mar 2019 11:06:48 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org
Cc:     ast@...nel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf] bpf: only test gso type on gso packets

On 03/06/2019 08:35 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> BPF can adjust gso only for tcp bytestreams. Fail on other gso types.
> 
> But only on gso packets. It does not touch this field if !gso_size.
> 
> Fixes: b90efd225874 ("bpf: only adjust gso_size on bytestream protocols")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Good catch, applied, thanks!

> Stupid bug on my part. Found only when adding tests for the feature.
> Will try to upstream those once bpf-next opens.
> 
> On a related note, also working on a flag BPF_F_ADJ_ROOM_FIXED_GSO
> that will allow reenabling this field for UDP (and possibly avoiding
> the expensive skb_cow for the TCP common case).

Nice, looking forward!