netdev - Re: [PATCH net] net: sched: put back q.qlen into a single location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ccbbbc1393e55ee8a199b1bdd0e36087fa6d71d.camel@redhat.com>
Date:   Fri, 08 Mar 2019 12:01:41 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        John Fastabend <john.fastabend@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ivan Vecera <ivecera@...hat.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] net: sched: put back q.qlen into a single location

Hi,

Thank you for fixing this!

On Thu, 2019-02-28 at 12:55 -0800, Eric Dumazet wrote:
> Later (net-next) we might revert this patch by tracking all these
> qlen uses and replace them by a more efficient method (not having
> to access a precise qlen, but an empty/non_empty status that might
> be less expensive to maintain/track).

We are working on this. The final goal is using this info to enable
TCQ_F_CAN_BYPASS for nolock qdisc, too, as we see regressions in
uncontended scenarios with pfifo_fast compared to pre TCQ_F_NOLOCK
implementation.

Please let us know if the "empty/non_empty status" refactor is in your
radar, so we can avoid conflicts.

Thanks!

Paolo