netdev - Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB=W+ok7qba3Kqr8USc-tKERLTnVnO8M+DO5wEqqoED0jnVoUA@mail.gmail.com>
Date:   Mon, 11 Mar 2019 22:18:13 -0600
From:   Captain Wiggum <captwiggum@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Florian Westphal <fw@...len.de>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

In case it is useful, this was the bisect test progress:

my-build-name     test   commit/release
----------------  -----  --------------
kernel-4.9.133-1  good   [deb3303f665b31c29210ef4b30b1e69cb06cc397]
Linux 4.9.133
kernel-4.9.134-1  bad    [1d326a94d1039e4543edd97cbaf0fc38d2cefbb5]
Linux 4.9.134
kernel-4.9.133-2  good   [7f10b7e254b3e30bcac471de29e562aff4e22c60]
net: dsa: bcm_sf2: Fix unbind ordering
kernel-4.9.133-3  good   [7f6170683223cb38cabaff21ecbb9a6375ad10f6]
inet: frags: break the 2GB limit for frags storage
kernel-4.9.133-4  good   [871695951ec6f6b0b1a258c9bb5336bfeffab409]
net: modify skb_rbtree_purge to return the truesize
kernel-4.9.133-5  bad    [10043954eadac2d8f8c1886190f7a7ee584ff939]
ip: use rb trees for IP frag queue.
kernel-4.9.133-6  bad    [791521e2e377f66ef5ee6e5002dec758234d8d32]
net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends
kernel-4.9.133-7  bad    [a8444b1ccb20339774af58e40ad42296074fb484]
ipv6: defrag: drop non-last frags smaller than min mtu
$ git bisect bad
74fb484 is the first bad commit

On Mon, Mar 11, 2019 at 10:12 PM Captain Wiggum <captwiggum@...il.com> wrote:
>
> Hi All,
>
> To summarize this thread, we test for IPv6 Ready Logo using Self-test
> Tools (TAHI Project) here:
> https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols
>
> 4.9.133 and previous passed 100%. Beginning with 4.9.134 it fails 18
> tests related to IPv6 fragment headers.
> I have done a git bisect, built and tested 7 revisions between 4.9.133
> - 4.9.134, this is the final bisect result:
> ------
> $ git bisect bad
> a8444b1ccb20339774af58e40ad42296074fb484 is the first bad commit
> commit a8444b1ccb20339774af58e40ad42296074fb484
> Author: Florian Westphal <fw@...len.de>
> Date:   Wed Oct 10 12:30:10 2018 -0700
> ipv6: defrag: drop non-last frags smaller than min mtu
> ------
> Also I believe it fails in all kernels since then, 4.19, stable, etc.
> Would it be possible for someone to look at that?
> Any tips appreciated.
>
> --John Masinter