netdev - Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9aec5c97-a488-8b75-60e9-ff9c198c636b@gmail.com>
Date:   Mon, 11 Mar 2019 21:20:25 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Captain Wiggum <captwiggum@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Florian Westphal <fw@...len.de>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Peter Oskolkov <posk@...gle.com>
Subject: Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9



On 03/11/2019 09:12 PM, Captain Wiggum wrote:
> Hi All,
> 
> To summarize this thread, we test for IPv6 Ready Logo using Self-test
> Tools (TAHI Project) here:
> https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols
> 
> 4.9.133 and previous passed 100%. Beginning with 4.9.134 it fails 18
> tests related to IPv6 fragment headers.
> I have done a git bisect, built and tested 7 revisions between 4.9.133
> - 4.9.134, this is the final bisect result:
> ------
> $ git bisect bad
> a8444b1ccb20339774af58e40ad42296074fb484 is the first bad commit
> commit a8444b1ccb20339774af58e40ad42296074fb484
> Author: Florian Westphal <fw@...len.de>
> Date:   Wed Oct 10 12:30:10 2018 -0700
> ipv6: defrag: drop non-last frags smaller than min mtu
> ------
> Also I believe it fails in all kernels since then, 4.19, stable, etc.
> Would it be possible for someone to look at that?
> Any tips appreciated.
> 
> --John Masinter
> 

Hi John

Yes, this is basically what I answered last week about this problem,
there was no need for a bisection :/

This has been solved in upstream kernels with this patch, not yet backported to v4.9.xxx

d4289fcc9b16b89619ee1c54f829e05e56de8b9a net: IP6 defrag: use rbtrees for IPv6 defrag