netdev - Re: [PATCH v1 net] lan743x: Fix TX Stall Issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190313.134327.1436563233974528424.davem@davemloft.net>
Date:   Wed, 13 Mar 2019 13:43:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Bryan.Whitehead@...rochip.com
Cc:     netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net] lan743x: Fix TX Stall Issue

From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
Date: Wed, 13 Mar 2019 15:55:48 -0400

> It has been observed that tx queue may stall while downloading
> from certain web sites (example www.speedtest.net)
> 
> The cause has been tracked down to a corner case where
> the tx interrupt vector was disabled automatically, but
> was not re enabled later.
> 
> The lan743x has two mechanisms to enable/disable individual
> interrupts. Interrupts can be enabled/disabled by individual
> source, and they can also be enabled/disabled by individual
> vector which has been mapped to the source. Both must be
> enabled for interrupts to work properly.
> 
> The TX code path, primarily uses the interrupt enable/disable of
> the TX source bit, while leaving the vector enabled all the time.
> 
> However, while investigating this issue it was noticed that
> the driver requested the use of the vector auto clear feature.
> 
> The test above revealed a case where the vector enable was
> cleared unintentionally.
> 
> This patch fixes the issue by deleting the lines that request
> the vector auto clear feature to be used.
> 
> Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@...rochip.com>

Applied and queued up for -stable.