netdev - Re: [PATCH] net_sched: return correct value for *notify* functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190313.134856.2065276102124905498.davem@davemloft.net>
Date:   Wed, 13 Mar 2019 13:48:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wangzhike@...com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net_sched: return correct value for *notify* functions

From: Zhike Wang <wangzhike@...com>
Date: Mon, 11 Mar 2019 03:15:54 -0700

> It is confusing to directly use return value of netlink_send()/
> netlink_unicast() as the return value of *notify*, as it may be not
> error at all.
> 
> Example: in tc_del_tfilter(), after calling tfilter_del_notify(), it will
> goto errout if (err). However, the netlink_send()/netlink_unicast() will
> return positive value even for successful case. So it may not call
> tcf_chain_tp_remove() and so on to clean up the resource, as a result,
> resource is leaked.
> 
> It may be easier to only check the return value of tfilter_del_nofiy(),
> but it is more clean to correct all related functions.
> 
> Co-developed-by: Zengmo Gao <gaozengmo@...com>
> Signed-off-by: Zhike Wang <wangzhike@...com>

Applied.