netdev - Re: [PATCH 1/1] bpftool: Allow referring to maps by its name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315195142.GB22548@kernel.org>
Date:   Fri, 15 Mar 2019 16:51:42 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Martin KaFai Lau <kafai@...com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Song Liu <songliubraving@...com>,
        Stanislav Fomichev <sdf@...gle.com>,
        Yonghong Song <yhs@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] bpftool: Allow referring to maps by its name

Em Fri, Mar 15, 2019 at 12:16:32PM -0700, Jakub Kicinski escreveu:
> Please do keep the current model of name val, IOW dump map *name* pids..

I don't have a problem with that, but what would be the problem with
supporting both:

  bpftool map dump name pids_filtered

and:

  bpftool map dump pids_filtered

And for that matter, even:

  bpftool map dump id 30

And

  bpftool map dump 30

Ditto for 'pinned'?

I.e. less typing, the tool can be smart enough to figure out what is
that is being asked, i.e. is it a number? Try first it as an 'id', etc.

- Arnaldo
 
> >   [{
> >           "key": 26554,
> >           "value": true
> >       },{
> >           "key": 2592,
> >           "value": true
> >       }
> >   ]
> >   #
> > 
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Daniel Borkmann <daniel@...earbox.net>
> > Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Martin KaFai Lau <kafai@...com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Quentin Monnet <quentin.monnet@...ronome.com>
> > Cc: Song Liu <songliubraving@...com>
> > Cc: Stanislav Fomichev <sdf@...gle.com>
> > Cc: Yonghong Song <yhs@...com>
> > Link: https://lkml.kernel.org/n/tip-rrnxuhvety3j3rf0r9zlbfro@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Please also update the bash completions and all the help/mans/docs.

-- 

- Arnaldo