netdev - Re: [PATCH 1/1] bpftool: Allow referring to maps by its name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315131853.13f45a70@cakuba.netronome.com>
Date:   Fri, 15 Mar 2019 13:18:53 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Martin KaFai Lau <kafai@...com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Song Liu <songliubraving@...com>,
        Stanislav Fomichev <sdf@...gle.com>,
        Yonghong Song <yhs@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] bpftool: Allow referring to maps by its name

On Fri, 15 Mar 2019 16:51:42 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 15, 2019 at 12:16:32PM -0700, Jakub Kicinski escreveu:
> > Please do keep the current model of name val, IOW dump map *name* pids..  
> 
> I don't have a problem with that, but what would be the problem with
> supporting both:
> 
>   bpftool map dump name pids_filtered
> 
> and:
> 
>   bpftool map dump pids_filtered
> 
> And for that matter, even:
> 
>   bpftool map dump id 30
> 
> And
> 
>   bpftool map dump 30
> 
> Ditto for 'pinned'?
> 
> I.e. less typing, the tool can be smart enough to figure out what is
> that is being asked, i.e. is it a number? Try first it as an 'id', etc.

It's error prone, we have excellent bash completions and accept
prefixing (bpftool m d n pids_filtered), so typing should not be 
a problem.