lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Mar 2019 11:45:40 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Aaro Koskinen <aaro.koskinen@....fi>, "David S. Miller" <davem@...emloft.net>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, Thor Thayer <thor.thayer@...ux.intel.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Aaro Koskinen <aaro.koskinen@...ia.com> Subject: Re: [PATCH 1/2] net: stmmac: don't set own bit too early for jumbo frames Hello! On 14.03.2019 22:43, Aaro Koskinen wrote: > From: Aaro Koskinen <aaro.koskinen@...ia.com> > > Commit 0e80bdc9a72d ("stmmac: first frame prep at the end of xmit > routine") overlooked jumbo frames when re-ordering the code, and as a > result the own bit was not getting set anymore for the first jumbo frame > descriptor. Commit 487e2e22ab79 ("net: stmmac: Set OWN bit for jumbo > frames") tried to fix this, but now the bit is getting set too early and > the DMA may start while we are still setting up the remaing descriptors. Remaining? > And with the chain mode the own bit remains still unset. > > Fix by setting the own bit at the end of xmit also with jumbo frames. > > Fixes: 0e80bdc9a72d ("stmmac: first frame prep at the end of xmit routine") > Fixes: 487e2e22ab79 ("net: stmmac: Set OWN bit for jumbo frames") > Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com> [...] MBR, Sergei
Powered by blists - more mailing lists