lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Mar 2019 11:58:50 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Kangjie Lu <kjlu@....edu> Cc: pakki001@....edu, Jon Maloy <jon.maloy@...csson.com>, Ying Xue <ying.xue@...driver.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: tipc: fix a missing check of nla_nest_start Hello! On 15.03.2019 9:07, Kangjie Lu wrote: > nla_nest_start could fail and requires a check. The fix returns > -EMSGSIZE if it fails. > > Signed-off-by: Kangjie Lu <kjlu@....edu> > --- > net/tipc/group.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/tipc/group.c b/net/tipc/group.c > index 06fee142f09f..117867e480ba 100644 > --- a/net/tipc/group.c > +++ b/net/tipc/group.c > @@ -918,6 +918,8 @@ void tipc_group_member_evt(struct tipc_group *grp, > int tipc_group_fill_sock_diag(struct tipc_group *grp, struct sk_buff *skb) > { > struct nlattr *group = nla_nest_start(skb, TIPC_NLA_SOCK_GROUP); Please keep the empty line after the declarations. > + if (!group) > + return -EMSGSIZE; > > if (nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_ID, > grp->type) || MBR, Sergei
Powered by blists - more mailing lists