netdev - Re: [Patch net] bluetooth: validate HCI_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpVCz3mG+ZUx5-U__y19n3qydVJuR2a+cnfHJJL_vMzPsA@mail.gmail.com>
Date:   Mon, 18 Mar 2019 18:32:13 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:     syzbot <syzbot+cec7a50c412a2c03f8f5@...kaller.appspotmail.com>,
        syzbot <syzbot+660883c56e2fa65d4497@...kaller.appspotmail.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>
Subject: Re: [Patch net] bluetooth: validate HCI_EVENT_PKT packet carefully

On Mon, Mar 18, 2019 at 1:45 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
> @@ -3978,6 +3982,9 @@ static void hci_inquiry_result_with_rssi_evt(struct hci_dev *hdev,
>
>         if ((skb->len - 1) / num_rsp != sizeof(struct inquiry_info_with_rssi)) {
>                 struct inquiry_info_with_rssi_and_pscan_mode *info;
> +
> +               if (unlikely(!pskb_may_pull(skb, num_rsp * sizeof(*info))))
> +                       goto unlock;

Here it should be 1 + num_rsp * sizeof(...).

I will send v2 after getting other feedbacks.

Thanks!