netdev - Re: [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Mar 2019 18:31:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        marcelo.leitner@...il.com, nhorman@...driver.com
Subject: Re: [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style
 sockets on some setsockopts

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 18 Mar 2019 20:05:58 +0800

> This is a patchset to fix ignoring asoc_id for tcp-style sockets on
> some setsockopts, introduced by SCTP_CURRENT_ASSOC of the patchset:
> 
>   [net-next,00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC
>   (https://patchwork.ozlabs.org/cover/1031706/)
> 
> As Marcelo suggested, we fix it on each setsockopt that is using
> SCTP_CURRENT_ASSOC one by one by adding the check:
> 
>     if (sctp_style(sk, TCP))
>         	xxx.xxx_assoc_id = SCTP_FUTURE_ASSOC;
> 
> so that assoc_id will be completely ingored for tcp-style socket on
> setsockopts, and works as SCTP_FUTURE_ASSOC.

Series applied, thanks Xin.