netdev - Re: [PATCH] tcp: don't use __constant_cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190319012914.GA9313@jagdpanzerIV>
Date:   Tue, 19 Mar 2019 10:29:14 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Stanislav Fomichev <sdf@...ichev.me>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tcp: don't use __constant_cpu_to_be32

On (03/18/19 09:32), Stanislav Fomichev wrote:
[..]
> > -#define bpf_htons(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_htons(x) : __bpf_htons(x))
> > -#define bpf_ntohs(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_ntohs(x) : __bpf_ntohs(x))
> > -#define bpf_htonl(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_htonl(x) : __bpf_htonl(x))
> > -#define bpf_ntohl(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_ntohl(x) : __bpf_ntohl(x))
> > +#define bpf_htons(x)	__bpf_htons((x))
> > +#define bpf_ntohs(x)	__bpf_ntohs((x))
> > +#define bpf_htonl(x)	__bpf_htonl((x))
> > +#define bpf_ntohl(x)	__bpf_ntohl((x))
> At this point we can probably drop __bpf_xxx as well?
> Care to resend with proper description when bpf-next opens?

OK.

	-ss