netdev - Re: [PATCH] net: stmmac: fix memory corruption with large MTUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92e465e5-0c77-e22f-d7e1-4689f3d655e7@synopsys.com>
Date:   Tue, 19 Mar 2019 10:36:19 +0000
From:   Jose Abreu <jose.abreu@...opsys.com>
To:     Aaro Koskinen <aaro.koskinen@....fi>,
        "David S. Miller" <davem@...emloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <jose.abreu@...opsys.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     Aaro Koskinen <aaro.koskinen@...ia.com>
Subject: Re: [PATCH] net: stmmac: fix memory corruption with large MTUs

On 3/18/2019 9:36 PM, Aaro Koskinen wrote:
>  	/* Fill DES3 in case of RING mode */
> -	if (priv->dma_buf_sz >= BUF_SIZE_8KiB)
> +	if (priv->dma_buf_sz == BUF_SIZE_16KiB)

Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ?

Thanks,
Jose Miguel Abreu