netdev - RE: [PATCH] net: stmmac: fix memory corruption with large MTUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0701MB2487FF2B8D4C0219DD209952F4400@DB6PR0701MB2487.eurprd07.prod.outlook.com>
Date:   Tue, 19 Mar 2019 11:07:33 +0000
From:   "Koskinen, Aaro (Nokia - FI/Espoo)" <aaro.koskinen@...ia.com>
To:     Jose Abreu <jose.abreu@...opsys.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        "David S. Miller" <davem@...emloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: stmmac: fix memory corruption with large MTUs

Hi,

From: Jose Abreu [jose.abreu@...opsys.com]:
> On 3/18/2019 9:36 PM, Aaro Koskinen wrote:
> >       /* Fill DES3 in case of RING mode */
> > -     if (priv->dma_buf_sz >= BUF_SIZE_8KiB)
> > +     if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>
> Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ?

I think it should be the same as in stmmac_init_rx_buffers():

        if (priv->dma_buf_sz == BUF_SIZE_16KiB)
                stmmac_init_desc3(priv, p);

A.