netdev - Re: [PATCH net-next v3 01/12] net: sched: flower: don't check for rtnl on head dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321135157.GI2087@nanopsycho>
Date:   Thu, 21 Mar 2019 14:51:57 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, sbrivio@...hat.com
Subject: Re: [PATCH net-next v3 01/12] net: sched: flower: don't check for
 rtnl on head dereference

Thu, Mar 21, 2019 at 02:17:33PM CET, vladbu@...lanox.com wrote:
>Flower classifier only changes root pointer during init and destroy. Cls
>API implements reference counting for tcf_proto, so there is no danger of
>concurrent access to tp when it is being destroyed, even without protection
>provided by rtnl lock.
>
>Implement new function fl_head_dereference() to dereference tp->root
>without checking for rtnl lock. Use it in all flower function that obtain
>head pointer instead of rtnl_dereference().
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>