netdev - Re: [PATCH net-next v3 02/12] net: sched: flower: refactor fl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321135320.GJ2087@nanopsycho>
Date:   Thu, 21 Mar 2019 14:53:20 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, sbrivio@...hat.com
Subject: Re: [PATCH net-next v3 02/12] net: sched: flower: refactor fl_change

Thu, Mar 21, 2019 at 02:17:34PM CET, vladbu@...lanox.com wrote:
>As a preparation for using classifier spinlock instead of relying on
>external rtnl lock, rearrange code in fl_change. The goal is to group the
>code which changes classifier state in single block in order to allow
>following commits in this set to protect it from parallel modification with
>tp->lock. Data structures that require tp->lock protection are mask
>hashtable and filters list, and classifier handle_idr.
>
>fl_hw_replace_filter() is a sleeping function and cannot be called while
>holding a spinlock. In order to execute all sequence of changes to shared
>classifier data structures atomically, call fl_hw_replace_filter() before
>modifying them.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>