netdev - Re: [PATCH net-next v3 03/12] net: sched: flower: introduce reference counting for filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321140005.GK2087@nanopsycho>
Date:   Thu, 21 Mar 2019 15:00:05 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, sbrivio@...hat.com
Subject: Re: [PATCH net-next v3 03/12] net: sched: flower: introduce
 reference counting for filters

Thu, Mar 21, 2019 at 02:17:35PM CET, vladbu@...lanox.com wrote:
>Extend flower filters with reference counting in order to remove dependency
>on rtnl lock in flower ops and allow to modify filters concurrently.
>Reference to flower filter can be taken/released concurrently as soon as it
>is marked as 'unlocked' by last patch in this series. Use atomic reference
>counter type to make concurrent modifications safe.
>
>Always take reference to flower filter while working with it:
>- Modify fl_get() to take reference to filter.
>- Implement tp->put() callback as fl_put() function to allow cls API to
>release reference taken by fl_get().
>- Modify fl_change() to assume that caller holds reference to fold and take
>reference to fnew.
>- Take reference to filter while using it in fl_walk().
>
>Implement helper functions to get/put filter reference counter.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>