netdev - Re: [PATCH net-next v3 04/12] net: sched: flower: track filter deletion with flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321140442.GL2087@nanopsycho>
Date:   Thu, 21 Mar 2019 15:04:42 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, sbrivio@...hat.com
Subject: Re: [PATCH net-next v3 04/12] net: sched: flower: track filter
 deletion with flag

Thu, Mar 21, 2019 at 02:17:36PM CET, vladbu@...lanox.com wrote:
>In order to prevent double deletion of filter by concurrent tasks when rtnl
>lock is not used for synchronization, add 'deleted' filter field. Check
>value of this field when modifying filters and return error if concurrent
>deletion is detected.
>
>Refactor __fl_delete() to accept pointer to 'last' boolean as argument,
>and return error code as function return value instead. This is necessary
>to signal concurrent filter delete to caller.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>