netdev - Re: [net v2 1/1] tipc: fix cancellation of topology subscriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 09:10:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net v2 1/1] tipc: fix cancellation of topology subscriptions

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 21 Mar 2019 09:11:59 +0100

> From: Erik Hugne <erik.hugne@...il.com>
> 
> When cancelling a subscription, we have to clear the cancel bit in the
> request before iterating over any established subscriptions with memcmp.
> Otherwise no subscription will ever be found, and it will not be
> possible to explicitly unsubscribe individual subscriptions.
> 
> Fixes: 8985ecc7c1e0 ("tipc: simplify endianness handling in topology subscriber")
> Signed-off-by: Erik Hugne <erik.hugne@...il.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>
> 
> ---
> v2: clear bit in a more sensible way.. (comment from davem)

Applied and queued up for -stable.

Thanks for following up.