netdev - Re: [PATCH net-next v2] tls: Add SOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190322.102423.745337199314721269.davem@davemloft.net>
Date:   Fri, 22 Mar 2019 10:24:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     borisp@...lanox.com
Cc:     davejwatson@...com, aviadye@...lanox.com, john.fastabend@...il.com,
        daniel@...earbox.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] tls: Add SOL_TLS to uapi

From: Boris Pismenny <borisp@...lanox.com>
Date: Thu, 21 Mar 2019 16:29:02 +0200

> User applications are forced to define the SOL_TLS manually at the
> moment, which is inappropriate. Add SOL_TLS to the uapi.
> 
> Other protocols handle this similarly. For example see SOL_TIPC.
> 
> Signed-off-by: Boris Pismenny <borisp@...lanox.com>
> ---
> v1: update commit message

Where did this convention come from where we define SOL_* in
linux/socket.h and then have to do this ifdef dance in the per-family
UAPI header?

AF_ALG and AF_KCM never did this, but I see that AF_TIPC did.

There really has to be a better way.