netdev - Re: [PATCH net-next v2] tls: Add SOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <748ce50c-fc9e-23af-0e93-b90b7a25bf3d@mellanox.com>
Date:   Fri, 22 Mar 2019 14:32:45 +0000
From:   Boris Pismenny <borisp@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     "davejwatson@...com" <davejwatson@...com>,
        Aviad Yehezkel <aviadye@...lanox.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] tls: Add SOL_TLS to uapi



On 3/22/2019 3:24 PM, David Miller wrote:
> From: Boris Pismenny <borisp@...lanox.com>
> Date: Thu, 21 Mar 2019 16:29:02 +0200
> 
>> User applications are forced to define the SOL_TLS manually at the
>> moment, which is inappropriate. Add SOL_TLS to the uapi.
>>
>> Other protocols handle this similarly. For example see SOL_TIPC.
>>
>> Signed-off-by: Boris Pismenny <borisp@...lanox.com>
>> ---
>> v1: update commit message
> 
> Where did this convention come from where we define SOL_* in
> linux/socket.h and then have to do this ifdef dance in the per-family
> UAPI header?
> 

The source for this is not known to me.
I've saw that this issue was mentioned and fixed in libc:
http://sourceware.org/ml/libc-alpha/2016-05/msg00322.html

> AF_ALG and AF_KCM never did this, but I see that AF_TIPC did.
> 
> There really has to be a better way.
> 

Maybe libc maintainers need to be notified whenever linux/socket.h is 
modified.