netdev - Re: r8169 driver from kernel 5.0 crashing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5870baca-9d1b-b75f-6406-4ba0cee1dbe8@gmail.com>
Date:   Fri, 22 Mar 2019 20:03:45 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     VDR User <user.vdr@...il.com>
Cc:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        netdev@...r.kernel.org
Subject: Re: r8169 driver from kernel 5.0 crashing - napi_consume_skb

On 21.03.2019 20:35, VDR User wrote:
>>> Just a quick check-in...  I was able to do a decent amount of testing
>>> yesterday after applying Heiner's patches that "removes an extra PCI
>>> register read in the
>>> interrupt handler" and adds some debug logging. So far I haven't seen
>>> any crashes, everything has been smooth. It may be worth noting that
>>> the last few crashes I saw occurred with less testing than I did
>>> yesterday. I'm not sure if luck is involved and will continue to test
>>> over the next few days unless otherwise instructed. Just wanted to
>>> keep you guys informed what I've seen so far.
>>>
>> Thanks a lot for the feedback and your efforts! If the issue doesn't
>> occur again in the next days I'll submit the fix.
> 
> Since my last check-in, I have done a ton more testing, hammering the
> nic with both directions of traffic. Not a single crash yet! At this
> point I feel very confident that problem has been resolved with your
> patch and would be very surprised if I see a crash going forward.
> Unless there are reasons unknown to me I'd say the patch/fix is
> ACK-worthy.
> 
> Thank you to everyone who helped sort this out!
> Derek
> 
Fix has been applied and should show-up in the stable tree very soon.

Heiner