netdev - Re: [PATCH v2] net: use bulk free in kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190324192302.5503031b@carbon>
Date:   Sun, 24 Mar 2019 19:23:02 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Felix Fietkau <nbd@....name>
Cc:     brouer@...hat.com, netdev@...r.kernel.org, davem@...emloft.net,
        fw@...len.de
Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list

On Sun, 24 Mar 2019 17:56:44 +0100
Felix Fietkau <nbd@....name> wrote:

> Since we're freeing multiple skbs, we might as well use bulk free to save a
> few cycles. Use the same conditions for bulk free as in napi_consume_skb.
> 
> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
> v2: call kmem_cache_free_bulk once the skb array is full instead of
>     falling back to kfree_skb

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer