netdev - Re: [PATCH v2] net: use bulk free in kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d7fd814-9525-f0a6-95ff-cccc2de8ecd8@gmail.com>
Date:   Mon, 25 Mar 2019 01:51:39 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Felix Fietkau <nbd@....name>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, brouer@...hat.com, fw@...len.de
Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list



On 03/24/2019 09:56 AM, Felix Fietkau wrote:
> Since we're freeing multiple skbs, we might as well use bulk free to save a
> few cycles. Use the same conditions for bulk free as in napi_consume_skb.
> 

I do not believe kfree_skb_list() is used in the fast path, so do we really
need to make it so complex ?