netdev - Re: [PATCH 1/3] net: xilinx: fix possible object reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190323.212144.1996374900941336844.davem@davemloft.net>
Date:   Sat, 23 Mar 2019 21:21:44 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     wen.yang99@....com.cn
Cc:     linux-kernel@...r.kernel.org, wang.yi59@....com.cn,
        anirudh@...inx.com, John.Linn@...inx.com, michal.simek@...inx.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] net: xilinx: fix possible object reference leak

From: Wen Yang <wen.yang99@....com.cn>
Date: Fri, 22 Mar 2019 11:04:07 +0800

> The call to of_parse_phandle returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> 
> Detected by coccinelle with the following warnings:
> ./drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1624:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1569, but without a corresponding object release within this function.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>

Applied.