netdev - Re: [net-next] net: dsa: Avoid null pointer when failing to connect to PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c5b8e6c-e76c-0e47-e0fd-809af3e78a27@gmail.com>
Date:   Sat, 23 Mar 2019 18:17:45 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [net-next] net: dsa: Avoid null pointer when failing to connect
 to PHY



On 3/23/2019 4:24 PM, Vladimir Oltean wrote:
> When phylink_of_phy_connect fails, dsa_slave_phy_setup tries to save the
> day by connecting to an alternative PHY, none other than a PHY on the
> switch's internal MDIO bus, at an address equal to the port's index.
> 
> However this does not take into consideration the scenario when the
> switch that failed to probe an external PHY does not have an internal
> MDIO bus at all.
> 
> Fixes: aab9c4067d23 ("net: dsa: Plug in PHYLINK support")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

This goes back to before that commit, pretty much since
0d8bcdd383b8865e752a7e8edb4712c2e3902052 ("net: dsa: allow for more
complex PHY setups").
-- 
Florian