netdev - Re: [net-next] net: dsa: Avoid null pointer when failing to connect to PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190326.112717.419592136707505524.davem@davemloft.net>
Date:   Tue, 26 Mar 2019 11:27:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...il.com
Subject: Re: [net-next] net: dsa: Avoid null pointer when failing to
 connect to PHY

From: Vladimir Oltean <olteanv@...il.com>
Date: Sun, 24 Mar 2019 01:24:07 +0200

> When phylink_of_phy_connect fails, dsa_slave_phy_setup tries to save the
> day by connecting to an alternative PHY, none other than a PHY on the
> switch's internal MDIO bus, at an address equal to the port's index.
> 
> However this does not take into consideration the scenario when the
> switch that failed to probe an external PHY does not have an internal
> MDIO bus at all.
> 
> Fixes: aab9c4067d23 ("net: dsa: Plug in PHYLINK support")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied.