lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Mar 2019 10:09:29 +0100 From: Felix Fietkau <nbd@....name> To: Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org Cc: davem@...emloft.net, brouer@...hat.com, fw@...len.de Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list On 2019-03-25 09:51, Eric Dumazet wrote: > > > On 03/24/2019 09:56 AM, Felix Fietkau wrote: >> Since we're freeing multiple skbs, we might as well use bulk free to save a >> few cycles. Use the same conditions for bulk free as in napi_consume_skb. >> > > I do not believe kfree_skb_list() is used in the fast path, so do we really > need to make it so complex ? mac80211 uses it to free the fraglist from A-MSDU aggregated packets in the tx status path. That's one fast path where it gets used right now and the reason it was showing up in my perf traces. - Felix
Powered by blists - more mailing lists