netdev - Re: [PATCH v2] net: use bulk free in kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37b3be81-f86d-3805-10d3-177e66d8d8f7@gmail.com>
Date:   Mon, 25 Mar 2019 02:31:29 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Felix Fietkau <nbd@....name>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, brouer@...hat.com, fw@...len.de
Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list



On 03/25/2019 02:09 AM, Felix Fietkau wrote:
> On 2019-03-25 09:51, Eric Dumazet wrote:
>>
>>
>> On 03/24/2019 09:56 AM, Felix Fietkau wrote:
>>> Since we're freeing multiple skbs, we might as well use bulk free to save a
>>> few cycles. Use the same conditions for bulk free as in napi_consume_skb.
>>>
>>
>> I do not believe kfree_skb_list() is used in the fast path, so do we really
>> need to make it so complex ?
> mac80211 uses it to free the fraglist from A-MSDU aggregated packets in
> the tx status path. That's one fast path where it gets used right now
> and the reason it was showing up in my perf traces.

This is not drop monitor friendly then....

TX completion should use consume_skb() or dev_kfree_skb()

BTW, I wonder what drop-monitor signal bulk free is sending ?