netdev - Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c90604e-2e3c-55da-6702-3759da7dc4d7@gmail.com>
Date:   Tue, 26 Mar 2019 06:02:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, linus.walleij@...aro.org,
        Georg Waibel <georg.waibel@...sor-technik.de>
Subject: Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP
 SJA1105 5-port L2 switch



On 3/23/2019 8:23 PM, Vladimir Oltean wrote:
> At this moment the following is supported:
> * Link state management through phylib

Not a show stopper for now, and your implementation looks sane, though I
would recommend implementing phylink to be future proof, and especially
since you support SGMII.

I was not able to review everything deeply so:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian